Skip to content

🚨 Fix LegacyKeyValueFormat report from docker build #152305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
homersimpsons wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🚨 Fix LegacyKeyValueFormat report from docker build #152305

homersimpsons wants to merge 1 commit into from
+232 −232

Conversation

@homersimpsons
Copy link
Contributor

@homersimpsons homersimpsons commented Feb 7, 2026 •
edited
Loading

While checking job logs (https://github.com/rust-lang/rust/actions/runs/21779827147/job/62842068357#step:28:217) I noticed:

   2 warnings found (use docker --debug to expand):
   - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 24)
   - LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format (line 29)

I identified warnings with:

git ls-files --directory **/Dockerfile | sed -E -e "s/(\/Dockerfile)//" |xargs --verbose --replace={} docker build --check {}

I went with ENV ENVVAR="quoted" because it is the most working solution I found. Note that I did not touch lines that did not report a warning but that were written as ENV ENVVAR=unquoted or ENV ENVVAR=multi \\n line.

FROM alpine

ENV INLINE_UNQUOTE=this is a test
ENV INLINE_QUOTE="this is a test"
ENV MULTILINE_UNQUOTE= \
  this \
  is \
  a \
  test
ENV MULTILINE_QUOTE="\
  this \
  is \
  a \
  test"

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 7, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 7, 2026

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: infra-ci
  • infra-ci expanded to Kobzol, Mark-Simulacrum, jdno, jieyouxu, marcoieni
  • Random selection from Mark-Simulacrum, jdno, jieyouxu, marcoieni

homersimpsons
homersimpsons commented Feb 7, 2026
View reviewed changes
src/ci/docker/host-aarch64/dist-aarch64-linux/Dockerfile
@@ -76,7 +76,7 @@ ENV HOSTS=aarch64-unknown-linux-gnu

ENV CPATH=/usr/include/aarch64-linux-gnu/:$CPATH
Copy link
Contributor Author

@homersimpsons homersimpsons Feb 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that here docker reports:

WARNING: UndefinedVar - https://docs.docker.com/go/dockerfile/rule/undefined-var/
Usage of undefined variable '$CPATH' (did you mean $PATH?)
src/ci/docker/host-aarch64/dist-aarch64-linux/Dockerfile:77
--------------------
  75 |     ENV HOSTS=aarch64-unknown-linux-gnu
  76 |
  77 | >>> ENV CPATH=/usr/include/aarch64-linux-gnu/:$CPATH
  78 |
  79 |     ENV RUST_CONFIGURE_ARGS=" \

I'm not sure if this warning should be fixed or if there is an error regarding this.

(That is the sole remaining warning after this commit)

homersimpsons
homersimpsons commented Feb 7, 2026
View reviewed changes
homersimpsons
homersimpsons commented Feb 7, 2026
View reviewed changes
@rust-log-analyzer

This comment has been minimized.

Sign in to view
homersimpsons
homersimpsons commented Feb 7, 2026
View reviewed changes
src/ci/docker/host-x86_64/x86_64-gnu-distcheck/Dockerfile
@@ -1,5 +1,5 @@
# Runs `distcheck`, which is a collection of smoke tests:
#
#
Copy link
Contributor Author

@homersimpsons homersimpsons Feb 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My IDE probably did that, should I revert?

homersimpsons
homersimpsons commented Feb 8, 2026
View reviewed changes
@homersimpsons homersimpsons marked this pull request as draft February 8, 2026 11:38
@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 8, 2026
@homersimpsons homersimpsons force-pushed the chore/fix-LegacyKeyValueFormat branch from e408c33 to 23a41c9 Compare February 8, 2026 12:54
@rust-log-analyzer

This comment has been minimized.

Sign in to view
homersimpsons
homersimpsons commented Feb 8, 2026
View reviewed changes
@homersimpsons homersimpsons force-pushed the chore/fix-LegacyKeyValueFormat branch from 23a41c9 to baef5fd Compare February 8, 2026 13:04
@homersimpsons homersimpsons marked this pull request as ready for review February 8, 2026 13:06
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 8, 2026
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@homersimpsons homersimpsons force-pushed the chore/fix-LegacyKeyValueFormat branch from baef5fd to 2ecbcb8 Compare February 8, 2026 22:26
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@homersimpsons homersimpsons force-pushed the chore/fix-LegacyKeyValueFormat branch from 2ecbcb8 to 20f7242 Compare February 8, 2026 23:35
homersimpsons
homersimpsons commented Feb 8, 2026
View reviewed changes
@homersimpsons homersimpsons force-pushed the chore/fix-LegacyKeyValueFormat branch from 20f7242 to ad71a75 Compare February 8, 2026 23:41
@rustbot
Copy link
Collaborator

rustbot commented Feb 8, 2026

The rustc-dev-guide subtree was changed. If this PR only touches the dev guide consider submitting a PR directly to rust-lang/rustc-dev-guide otherwise thank you for updating the dev guide with your changes.

cc @BoxyUwU, @jieyouxu, @Kobzol, @tshepang

@rustbot rustbot added the A-rustc-dev-guide Area: rustc-dev-guide label Feb 8, 2026
@homersimpsons homersimpsons force-pushed the chore/fix-LegacyKeyValueFormat branch from ad71a75 to 7254d82 Compare February 8, 2026 23:43
@homersimpsons homersimpsons force-pushed the chore/fix-LegacyKeyValueFormat branch from 7254d82 to 70e2fe3 Compare February 8, 2026 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@marcoieni marcoieni

Labels

A-CI Area: Our Github Actions CI A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@homersimpsons @rustbot @rust-log-analyzer @marcoieni